Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for valueless attribute selectors in selector-attribute-name-disallowed-list #5059

Closed
vkrol opened this issue Nov 23, 2020 · 0 comments · Fixed by #5060
Closed
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@vkrol
Copy link
Member

vkrol commented Nov 23, 2020

Clearly describe the bug

selector-attribute-name-disallowed-list doesn't handle valueless attribute selectors correctly.

Which rule, if any, is the bug related to?

selector-attribute-name-disallowed-list.

What code is needed to reproduce the bug?

[disabled] { }

What stylelint configuration is needed to reproduce the bug?

{
  "rules": {
    "selector-attribute-name-disallowed-list": ["disabled"]
  }
}

Which version of stylelint are you using?

13.8.0.

How are you running stylelint: CLI, PostCSS plugin, Node.js API?

CLI with stylelint "**/*.css" --config myconfig.json.

Does the bug relate to non-standard syntax (e.g. SCSS, Less etc.)?

No.

What did you expect to happen?

The warning was flagged.

What actually happened (e.g. what warnings or errors did you get)?

No warnings were flagged.

/cc @rletsin

@jeddy3 jeddy3 changed the title selector-attribute-name-disallowed-list doesn't handle valueless attribute selectors correctly Fix false positives for valueless attribute selectors in selector-attribute-name-disallowed-list Nov 24, 2020
@jeddy3 jeddy3 added status: wip is being worked on by someone type: bug a problem with a feature or rule labels Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
Development

Successfully merging a pull request may close this issue.

2 participants