Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit-no-unknown false positives for unicode-range descriptors #6891

Closed
Mister-Hope opened this issue Jun 4, 2023 · 3 comments · Fixed by #6892
Closed

Fix unit-no-unknown false positives for unicode-range descriptors #6891

Mister-Hope opened this issue Jun 4, 2023 · 3 comments · Fixed by #6892
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@Mister-Hope
Copy link

Mister-Hope commented Jun 4, 2023 •
edited

Reproduction

https://stylelint.io/demo/#N4Igxg9gJgpiBcID0AqABAGwIYBcCWAdgLQwAeOaKSAOgQAIBmEBORDWYMawtaaTLIgHcYeAOYALHPDQAWAAzyA3L37NWAZxwBPDDBl4cWDHjAqCfAa3YBbPBm0yAMrgjm+GgE5gZGCGGMACmoQFxwINABJIxMwEIBKABpMfyCQsIgiaONTBMTVPgBXTwxgkCkcAAcNeCQkKw0AOjEtXFNGyBskDSRscKQANwBGAHYkAGUANkKADiFZACEAWQBVABUABQAJACtSDQBBFbwiAEcAKQBhAE1GoQgGBgAmBIK+NU8bXDL7x5eQeLmVSFAimaAwIieLAEMT6NArADU8iGiiI8iesgAYslEeiAKwAThxCKGAFFUWTMdj4Qinuj5MS6Qd5EQmQt8hZ3oimQARVnyS7U7lDIYAZkZl0mLKelxGQoRBxGdKIiqp5gAvrQQIkQAx7DAAHJYGxwRBkY2VPQdDQabXgZh6sQIEA8TkhMg4GAEKAaEIyADabxCWl0MBMgkgBEdRFa3qwnigIVUAF1aOq7ZHHZiIJ9cM6dhpmHbYNVna6+MGdHpwzg-WgQn0YFoQhyKyAQ9XCKxM+IY0Y4wm6w3cE3ayA0yB1UA

Which version of Stylelint or dependencies are you using?

15.6.3

What did you expect to happen?

No problem

What actually happened?

error

Does the bug relate to non-standard syntax?

no
@Mister-Hope
Copy link
Author

Probably caused by 7206cfc

Mister-Hope referenced this issue Jun 4, 2023
@romainmenke @ybiquitous @chalkygames123
Fix unit-no-unknown false positives for the second and subsequent `…
7206cfc 
…image-set()` with `x` descriptor (#6879)


Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Takuya Fukuju <chalkygames123@gmail.com>
@Mister-Hope Mister-Hope changed the title unicode-range failed on 15.6.4 with unit-no-unknown unicode-range failed on 15.6.3 with unit-no-unknown Jun 4, 2023
@romainmenke
Copy link
Member

romainmenke commented Jun 4, 2023 •
edited

Thank you for reporting this @Mister-Hope

I can confirm the issue.

@ybiquitous I wrote the change that introduced this regression, so I went ahead and added a fix :)

@romainmenke romainmenke changed the title unicode-range failed on 15.6.3 with unit-no-unknown Fix unit-no-unknown false positives for unicode-range descriptors Jun 4, 2023
@romainmenke romainmenke mentioned this issue Jun 4, 2023
Merged
@romainmenke romainmenke added the type: bug a problem with a feature or rule label Jun 4, 2023
@ybiquitous ybiquitous added the status: wip is being worked on by someone label Jun 5, 2023
@ybiquitous
Copy link
Member

@Mister-Hope @romainmenke Thanks for the report and the quick-fix!

@romainmenke romainmenke mentioned this issue Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unit-no-unknown false positives for unicode-range descriptors stylelint/stylelint
3 participants
@ybiquitous @romainmenke @Mister-Hope