Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-pseudo-element-no-unknown false positives for view-transition pseudo-elements #7069

Closed
danielroe opened this issue Jul 10, 2023 · 1 comment · Fixed by #7070
Closed
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@danielroe
Copy link
Contributor

danielroe commented Jul 10, 2023

What minimal example or steps are needed to reproduce the bug?

::view-transition-old(menu) {
  transform: rotate(0deg);
}

What minimal configuration is needed to reproduce the bug?

{
  "rules": {
    "selector-pseudo-element-no-unknown": true
  }
}

How did you run Stylelint?

https://stylelint.io/demo/#N4Igxg9gJgpiBcD4DcCWMDuBaALgJwEMA7AZ1R1QiKwgBsoAKAWxiIFcBKAAmAB0iuXfMRIAzCHibwueCDgI4YDAAywA5hwDc-AL78QAGhCjUtGADkCLBCBgAPKwAczAOjAkSh8FRNqbfAS5eWztFIigSYOkAbX5BQWCSHABPM1pUIhwsSCJfLCTiKAI8KGC4rgBdXS8c3wAxCSYFGwArEiovWEdPRACEkCTUmHTMqKCQWgUYJOCDcsSUtIys2tQ1fPlw4tKEccnFGZBqnSA

Which Stylelint-related dependencies are you using?

{
  "stylelint": "15.10.1"
}

What did you expect to happen?

No problems to be reported.

What actually happened?

The following problems were reported:

 172:1  ✖  Unexpected unknown pseudo-element selector "::view-transition-old"  selector-pseudo-element-no-unknown

Do you have a proposal to fix the bug?

Add the new pseudo element selectors to the list, alongside other experimental ones like target-text and spelling-error. Note: I've reported this as a bug but it may of course be a feature, depending on how you think about it.

Documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/::view-transition

@jeddy3
Copy link
Member

jeddy3 commented Jul 10, 2023

@danielroe Thank you for the clear report, using the template and for the pull request.

Note: I've reported this as a bug but it may of course be a feature, depending on how you think about it.

You were right to as we typical class these as false positive bugs.

@jeddy3 jeddy3 added status: wip is being worked on by someone type: bug a problem with a feature or rule labels Jul 10, 2023
@jeddy3 jeddy3 changed the title Support view-transition pseudo-elements Fix selector-pseudo-element-no-unknown false positives for view-transition pseudo-elements Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
2 participants