Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 16.0.0 #7374

Closed
10 tasks done
jeddy3 opened this issue Dec 4, 2023 · 26 comments
Closed
10 tasks done

Release 16.0.0 #7374

jeddy3 opened this issue Dec 4, 2023 · 26 comments
Labels
status: wip is being worked on by someone

Comments

@jeddy3
Copy link
Member

jeddy3 commented Dec 4, 2023

I believe we're ready to release 16.0.0 once we:

Steps:

  • stylelint release
  • stylelint-config-recommended release
  • stylelint-config-standard release
  • jest-preset-stylelint release
  • stylelint-test-rule-node release
  • stylelint.io update
  • stylelint-demo check
  • tweet

@ybiquitous Thank you so much for all your efforts. Would you like to do the release, as you've contributed so much to it? I can support the process UK time tomorrow, Thur or Friday this week. I believe UK morning is Japan evening; which evening suits you best?

@jeddy3 jeddy3 added the status: needs discussion triage needs further discussion label Dec 4, 2023
@ybiquitous
Copy link
Member

@jeddy3 Thanks for your consideration. I'll be available 6-10pm JST on Thursday or Friday this week.

@jeddy3
Copy link
Member Author

jeddy3 commented Dec 5, 2023

Let's shoot for Friday, as I'm freer that UK morning.

@ybiquitous
Copy link
Member

Okay. I'll prepare the release stuff by Friday.

@ybiquitous
Copy link
Member

@jeddy3 I'm starting the release now. 🚀

@ybiquitous
Copy link
Member

Oops. I forgot PR #7376 is still open. I'll wait for it.

@jeddy3
Copy link
Member Author

jeddy3 commented Dec 8, 2023

@ybiquitous I've approved #7376

@ybiquitous
Copy link
Member

I've merged #7358. I'll publish 16.0.0 now.

@ybiquitous
Copy link
Member

npm & GitHub release published 🎉

@jeddy3 jeddy3 added status: wip is being worked on by someone and removed status: needs discussion triage needs further discussion labels Dec 8, 2023
@newives
Copy link

newives commented Dec 8, 2023

图片

It seems that migration-guide/to-16 is missing

@ybiquitous
Copy link
Member

Yep, "stylelint.io update" has not started yet.

@ybiquitous
Copy link
Member

The packages and website are now published! 🎉

However, some contributors told me the type definitions had a bug, so I'll fix it soon and release a patch version 16.0.1:
#7309 (comment)

@jeddy3 Could you tweet as the last task of this release instead of me, please?

@eduardocque
Copy link

eduardocque commented Dec 8, 2023

guys after update to 16.0.0 im getting this error

TypeError: Cannot read properties of undefined (reading 'rejected')
    at Object.<anonymous> (/.../node_modules/stylelint-scss/src/rules/comment-no-empty/index.js:12:42)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/.../node_modules/stylelint-scss/src/rules/index.js:31:23)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)

@ybiquitous

Regards

@newives
Copy link

newives commented Dec 8, 2023

guys after update to 16.0.0 im getting this error更新到16.0.0后,我得到了这个错误

TypeError: Cannot read properties of undefined (reading 'rejected')
    at Object.<anonymous> (/.../node_modules/stylelint-scss/src/rules/comment-no-empty/index.js:12:42)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/.../node_modules/stylelint-scss/src/rules/index.js:31:23)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)

@ybiquitous

Regards问候

see #7322 (comment)

@eduardocque
Copy link

@newives what should i do ? i dont get it, thx

@newives
Copy link

newives commented Dec 8, 2023

Waiting for stylelint-scss to be upgraded stylelint-scss/stylelint-scss#894 (comment)

@ybiquitous
Copy link
Member

@newives Thanks. Yes, stylelint-scss needs to deal with Stylelint 16.0.0 breaking changes.

@eduardocque
Copy link

ohhh right, so i would need to wait, is there any workaround ? or should i do a downgrade ?

@ybiquitous
Copy link
Member

@eduardocque It seems to be no workaround. You should keep 15.x.

@eduardocque
Copy link

alright, thanks i will do that

@ybiquitous
Copy link
Member

@jeddy3 I'll tweet the 16.0.0 announce now since a contributor will send a PR to fix the type problem.

@jeddy3
Copy link
Member Author

jeddy3 commented Dec 8, 2023

@ybiquitous I just saw your message now. I can tweet unless you're already on it?

@ybiquitous
Copy link
Member

Ah, I've just tweeted right now. 😅

All tasks for this release are done! Thanks a lot for your contributions! 🎉

@jeddy3
Copy link
Member Author

jeddy3 commented Dec 8, 2023

The tweet looks good; thank you!

@ybiquitous
Copy link
Member

My tweet may be a bit unnatural. Please feel free to add extra tweets. 😅

I'm closing this issue. Please open a new issue if you have problems with 16.0.0.

@jeddy3
Copy link
Member Author

jeddy3 commented Dec 8, 2023

Thank you to everyone who contributed to this release: joining the discussions, committing code, reviewing pull requests, testing the prereleases, triaging issues and all the other bits we volunteer to do!

And a special thank you to @ybiquitous , who tirelessly drove our migration to ESM over the past year. It was a colossal effort.

@ybiquitous ybiquitous mentioned this issue Dec 8, 2023
4 tasks
@JounQin
Copy link
Member

JounQin commented Dec 8, 2023

Congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone
Development

No branches or pull requests

5 participants