Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning: fs.Stats constructor is deprecated #7680

Closed
doberkofler opened this issue May 8, 2024 · 6 comments · Fixed by #7683
Closed

DeprecationWarning: fs.Stats constructor is deprecated #7680

doberkofler opened this issue May 8, 2024 · 6 comments · Fixed by #7683
Labels
status: wip is being worked on by someone type: refactor an improvement to the code structure upstream relates to an upstream package

Comments

@doberkofler
Copy link

What is the problem you're trying to solve?

When running stylelint on nodejs 22.1.0 i get the following warning:

(node:57276) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
    at tryStatSync (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/@dual-bundle/import-meta-resolve/lib/resolve.js:139:12)
    at packageResolve (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/@dual-bundle/import-meta-resolve/lib/resolve.js:1002:18)
    at moduleResolve (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/@dual-bundle/import-meta-resolve/lib/resolve.js:1101:20)
    at defaultResolve (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/@dual-bundle/import-meta-resolve/lib/resolve.js:1266:15)
    at resolve (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/@dual-bundle/import-meta-resolve/index.js:32:12)
    at resolveSilent (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/stylelint/lib/utils/resolveSilent.mjs:49:35)
    at getModulePath (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/stylelint/lib/utils/getModulePath.mjs:18:13)
    at loadExtendedConfig (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/stylelint/lib/augmentConfig.mjs:230:21)
    at extendConfig (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/stylelint/lib/augmentConfig.mjs:198:25)
    at augmentConfigBasic (file:///Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/stylelint/lib/augmentConfig.mjs:60:26)

What solution would you like to see?

It would be nice to get rid of the warning
@Mouvedia Mouvedia added status: blocked is blocked by another issue or pr type: refactor an improvement to the code structure upstream relates to an upstream package status: ask to implement ask before implementing as may no longer be relevant and removed status: blocked is blocked by another issue or pr labels May 8, 2024
@Mouvedia
Copy link
Member

Mouvedia commented May 8, 2024 •
edited

We can patch the dependency if versions <14.17.0 are supported by @dual-bundle/import-meta-resolve.
i.e. return statSync(path, { throwIfNoEntry: false });

@ybiquitous
Copy link
Member

Thanks for the report. Yes, this warning is due to @dual-bundle/import-meta-resolve. See also #7556 (comment)

@ybiquitous
Copy link
Member

cc @JounQin

@JounQin
Copy link
Member

JounQin commented May 8, 2024

Sorry for the delay, I'll do it tomorrow.

@JounQin
Copy link
Member

JounQin commented May 9, 2024

@dual-bundle/import-meta-resolve@4.1.0 has been released.

cc @doberkofler

@ybiquitous ybiquitous linked a pull request May 9, 2024 that will close this issue
Bump @dual-bundle/import-meta-resolve from 4.0.0 to 4.1.0 #7683
Merged
@ybiquitous ybiquitous added status: wip is being worked on by someone and removed status: ask to implement ask before implementing as may no longer be relevant labels May 9, 2024
@ybiquitous
Copy link
Member

@JounQin Thanks for the new release! I just triggered Dependabot, and PR #7683 should resolve this issue.

Of course, even without PR #7638, you can update @dual-bundle/import-meta-resolve in your dependency tree via:

npm update @dual-bundle/import-meta-resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wip is being worked on by someone type: refactor an improvement to the code structure upstream relates to an upstream package
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump @dual-bundle/import-meta-resolve from 4.0.0 to 4.1.0 stylelint/stylelint
4 participants
@Mouvedia @ybiquitous @doberkofler @JounQin