You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Something is seriously broken here, need to investigate.
Easiest way to reproduce is to check task_publish-npm() function in runnerfile.sh.
Right now, npm publish || return "${?}" form is used, which errors out just fine, but npm publish || return does not error out. In fact, it returns 0 every time.
Will add tests someday, because this issue pops up multiple times.
The text was updated successfully, but these errors were encountered:
Currently the best solution seems to avoid conditional operators (||, &&) at all costs when chaining commands inside the "runner" itself, because they forcefully reset the set -e flag which you can't re-enable later.
It seems I have done a good job at keeping the next branch clean of such things. We can finally use set -e inside tasks, so you no longer need to write <command> || return ${?} everywhere.
Something is seriously broken here, need to investigate.
Easiest way to reproduce is to check
task_publish-npm()
function inrunnerfile.sh
.Right now,
npm publish || return "${?}"
form is used, which errors out just fine, butnpm publish || return
does not error out. In fact, it returns 0 every time.Will add tests someday, because this issue pops up multiple times.
The text was updated successfully, but these errors were encountered: