Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to write or edit styles while about:home is open #293

Open
quilloss opened this issue Aug 30, 2016 · 5 comments
Open

Unable to write or edit styles while about:home is open #293

quilloss opened this issue Aug 30, 2016 · 5 comments

Comments

@quilloss
Copy link

Firefox 50.0a2
Stylish 2.0.7
Clean profile with only Stylish installed.

When the about:home is open:

  1. I can't open the style editor from about:addons by clicking Write New Style.
  2. Directly navigating to about:stylish-edit works.

Closing about:home solves the issue.

Browser Console:
stylish_error

@yfdyh000
Copy link
Contributor

@quilloss
Copy link
Author

Does the stylishCommon.focusWindow function need to access any remote tabs?
If it does not the following should work.

https://github.com/JasonBarnabe/stylish/blob/master/content/common.js#L73
Replace if (browsers[i].currentURI.schemeIs("about")) { with if (!browsers[i].isRemoteBrowser && browsers[i].currentURI.schemeIs("about")) {

@yfdyh000
Copy link
Contributor

It looks work at least for now.

@tdim
Copy link

tdim commented Oct 4, 2016

Replace if (browsers[i].currentURI.schemeIs("about")) { with if (!browsers[i].isRemoteBrowser && browsers[i].currentURI.schemeIs("about")) {

thank you! this worked perfectly for me on Firefox Nightly 52.0a1 (2016-10-03) (64-bit) / Stylish 2.0.7

@NiklasGollenstede
Copy link

NiklasGollenstede commented Mar 17, 2017

I experience the exact same error with Firefox 53 / Stylish 2.0.7, only that I don't have about:home or any other remote about: tabs open (I think).

Is there a reason why this still hasn't been fixed? It doesn't seem to difficult ...


As a workaround, one can open about:stylish-edit?id=<id> manually of course. To get the <id>, open the User Styles tab on about:addons, press Ctrl+Shift+C, select the style to open and use the value attribute on the closest richlistitem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants