Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected links unreadable with same-color selection #82

Closed
silverwind opened this issue Dec 16, 2013 · 5 comments
Closed

Selected links unreadable with same-color selection #82

silverwind opened this issue Dec 16, 2013 · 5 comments

Comments

@silverwind
Copy link
Member

hili

We might have to come up with a different color based on what's selected, like a::-moz-selection. A shame you can't combine these selectors with anything.

@Mottie
Copy link
Member

Mottie commented Dec 16, 2013

It's a shame we can't use LESS or SCSS to shift the color slightly ;)

Should we just have two color settings? Main and alternate?

@silverwind
Copy link
Member Author

I think some trickery with a second background layer or a absolute positioned pseudo element could work to darken the selection while still keeping the base-color.

@Mottie
Copy link
Member

Mottie commented Dec 16, 2013

What about a text-shadow?

@silverwind
Copy link
Member Author

I oppose text-shadow wherever possible :)

@silverwind
Copy link
Member Author

I've been poking around with secondary background layers and pseudo elements (both of which won't work on ::-moz-selection) but then noticed that probly the best fix is actually pretty simple:

  /* text selection */
  ::selection {
    background: /*[[base-color]]*/ #4183C4 !important;
    color: #fff !important;
  }
  ::-moz-selection {
    background: /*[[base-color]]*/ #4183C4 !important;
    color: #fff !important;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants