Merge pull request #317 from samoli/improve-company-logos

Use more realistic logos
faker-ruby · Feb 4, 2015 · 3ad557c · 3ad557c
2 parents aba6c16 + e3516ee
commit 3ad557c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -134,8 +134,8 @@ Faker::Company.ein #=> "34-8488813"
 
 Faker::Company.duns_number #=> "08-341-3736"
 
-# Get a random company logo url in GIF format.
-Faker::Company.logo #=> "http://www.biz-logo.com/examples/007.gif"
+# Get a random company logo url in PNG format.
+Faker::Company.logo #=> "http://pigment.github.com/fake-logos/logos/medium/color/5.png"
 
 ```
 

diff --git a/lib/faker/company.rb b/lib/faker/company.rb
@@ -29,10 +29,10 @@ def duns_number
         ('%09d' % rand(10 ** 9)).gsub(/(\d\d)(\d\d\d)(\d\d\d\d)/, '\\1-\\2-\\3')
       end
 
-      # Get a random company logo url in GIF format.
+      # Get a random company logo url in PNG format.
       def logo
-        rand_num = Random.rand(76) + 1
-        "http://www.biz-logo.com/examples/#{ rand_num < 10 ? "00" : "0" }#{rand_num}.gif"
+        rand_num = Random.rand(13) + 1
+        "http://pigment.github.io/fake-logos/logos/medium/color/#{rand_num}.png"
       end
     end
 

diff --git a/test/test_faker_company.rb b/test/test_faker_company.rb
@@ -14,6 +14,6 @@ def test_duns_number
   end
 
   def test_logo
-	  assert @tester.logo.match(%r{http://www.biz-logo.com/examples/\d+\.gif})
+	  assert @tester.logo.match(%r{http://pigment.github.io/fake-logos/logos/medium/color/\d+\.png})
   end
 end