Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ukrainian entries to yml #1117

Merged
merged 3 commits into from May 20, 2018
Merged

Conversation

sturman
Copy link
Contributor

@sturman sturman commented Jan 17, 2018

  • Added Ukrainian entries to yml

@sturman
Copy link
Contributor Author

sturman commented May 15, 2018

Hi @vbrazo, could you please clarify what should I do with this PR?

@vbrazo vbrazo force-pushed the master branch 2 times, most recently from 1dbe328 to e1e54c6 Compare May 20, 2018 02:35
@vbrazo vbrazo self-requested a review May 20, 2018 19:29
@@ -73,3 +73,12 @@ uk:
- "#{prefix} #{Name.male_last_name}"
- "#{prefix} #{Address.city_name}#{product}#{suffix}"
- "#{prefix} #{Address.city_name}#{suffix}"

music:
instruments: ['Електрична гітара', 'Акустична гітара', 'Флейта', 'Труба', 'Кларнет', 'Віолончель', 'Арфа', 'Ксилофон', 'Гармоніка', 'Аккордеон', 'Орган', 'Піаніно', 'Укулеле', 'Саксофон', 'Барабан', 'Скрипка', 'Бас-гітара']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locales ❤️ 💛 🖤 💙 💚

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 👍 🥇

@vbrazo vbrazo merged commit 1d57920 into faker-ruby:master May 20, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:33
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* add music instruments

* added artists

* added Yoda quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants