Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::DrWho.actor #1272

Merged
merged 5 commits into from Jun 3, 2018
Merged

Add Faker::DrWho.actor #1272

merged 5 commits into from Jun 3, 2018

Conversation

timcustard
Copy link
Contributor

Added list of actors to Dr Who, and updated list of doctors to add 13th doctor.

@vbrazo vbrazo changed the title Dr who updates Add Faker::DrWho.actor Jun 3, 2018
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contributing 👍

@vbrazo
Copy link
Member

vbrazo commented Jun 3, 2018

I saw that there are a few commits from older changes. You should update your repository's master branch before creating a new branch in your repo.

@vbrazo vbrazo merged commit d51919c into faker-ruby:master Jun 3, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:22
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Added Symbols for Elements to Science

* Update CHANGELOG.md

* Added actors to Dr Who

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants