Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Games::HalfLife #1381

Merged
merged 5 commits into from Oct 4, 2018
Merged

Add Faker::Games::HalfLife #1381

merged 5 commits into from Oct 4, 2018

Conversation

jthomp
Copy link
Contributor

@jthomp jthomp commented Oct 2, 2018 •
edited

  • Faker::HalfLife.character
    • Returns a character from Half-Life 1 or 2 and expansions.
  • Faker::HalfLife.enemy
    • Returns an enemy from Half-Life 1 or 2 and expansions.
  • Faker::HalfLife.location
    • Returns a location from Half-Life 1 or 2 and expansions.

@jthomp
Add Faker::HalfLife
971ab76
@jthomp
add line for rubocop
f038b32 
add more comments to doc
fix a typo in a character name
add more enemies
@jthomp
remove duplicate enemy.
ae4777e
vbrazo
vbrazo approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Just a small favor: could you add a namespace for this module? I mean Faker::Games::HalfLife. We're starting to introduce namespaces and Faker::Games:: will be one of them.

Thanks.

@vbrazo
Copy link
Member

vbrazo commented Oct 2, 2018

You also need to update the README.md and add the new module @jthomp

@jthomp
update README
22d8192 
add namespace for Faker::Games
@jthomp
Copy link
Contributor Author

jthomp commented Oct 2, 2018

Added the namespace and updated the README 👍

@vbrazo vbrazo changed the title Add Faker::HalfLife Add Faker::Games::HalfLife Oct 4, 2018
@vbrazo vbrazo merged commit 7aedb71 into faker-ruby:master Oct 4, 2018
@vbrazo vbrazo mentioned this pull request Oct 25, 2018
Closed
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@jthomp @vbrazo
Add Faker::Games::HalfLife (faker-ruby#1381)
ada3598 
* Add Faker::HalfLife

* add line for rubocop
add more comments to doc
fix a typo in a character name
add more enemies

* remove duplicate enemy.

* Update half_life.md

* update README
add namespace for Faker::Games
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@jthomp jthomp

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jthomp @vbrazo