-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Secrets Manager Bearer Token Value Parsing #35
Comments
Hi Jimmy! The
But perhaps it could be phrased better? 🤔 |
So, maybe I am doing something wrong, but I don't see how you can enter just a Also, your hook config schema refers to the
|
So, if you use the plain-text, and not the key/value fields then it should work, for a value with no key. In the AWS CLI, it would be:
I guess the Perhaps it should be referenced as "Secret Name", instead. |
Ah, yes, that's probably from an older iteration! Thanks for pointing that out 👍 Do you want to submit a PR to remove that or should I? |
Does the AWS Secrets Manager bearer token value need parsing? Your code:
https://github.com/StyraInc/opa-aws-cloudformation-hook/blob/main/hooks/src/styra_opa_hook/handlers.py#L28-L44
Returns the
SecretString
from SecretsManager:{"opa_auth_token": "<VALUE>"}
.Are you expecting that entire string
{"opa_auth_token": "<VALUE>"}
to be configured in the OPA sever token auth? Or do we need to parse the actual value out with something like:The text was updated successfully, but these errors were encountered: