SARIF: level using incorrect value notice

[travbale]

Per SARIF §3.27.10 the value of level must be warning, error, note, or none.

The implict-future-keywords rule is setting to value to notice. Other rules may be impacted but I have observed it on that one specfically.

[anderseknert]

Thanks @travbale 👍 Looks like you're right, and we should translate our "notice" level to "note" for SARIF. Any tooling that breaks because of this?

[travbale]

SARIF Viewer for VsCode flags it as an error in the SARIF document.

[anderseknert]

Thanks again @travbale 👍 PRs up for both issues. That the implicit-future-keywords notice was included at all was a mistake of its own. There are essentially two types of notices at this point in time: 1) rules that have been excluded because some new capability or other rule made them obsolete and 2) rules that have been excluded because the targeted OPA version does not come with some more modern capability required by the rule.

Only the latter is interesting to most users, so that's the type we'll want to include in the reports (SARIF or not).

[travbale]

Thanks for the quick turn around! If I see anything else I will let you know.

[anderseknert]

Thanks @travbale! You could go build from main once these PRs are merged if you'd want to test it with the known issues resolved before the next release (~2 weeks or so from now).

[anderseknert]

Fixed with #516