Diagnostics reported remains after branch change where file doesn't exist

[anderseknert]

Creating "foo.rego" and deleting it doesn't seem to remove the diagnostics reported for that file.

[charlieegan3]

I was able to replicate this but now I can't. Do you remember anything you had in this env to make it happen?

[anderseknert]

No, seems to have been accidentally fixed somehow 😅 But I'll take it! Let's close and re-open if we encounter this again.

[charlieegan3]

yeah I am unsure what that would have been, 👍 we can keep an eye out.

[anderseknert]

While I'm not sure it counts as deletion, this can be triggered by having issues reported on one branch, then switching branch to one where that file doesn't exist. The errors reported remains.

[charlieegan3]

Hmm, this is hard as in this case the client didn't delete the file. (aka right click, delete).

I'd be interested to know what other language servers do here, but doing a full reload on branch change seems reasonable.

[anderseknert]

Yeah... there's probably a branch change listener somewhere in the client already, but ideally we'd be able to catch this without relying on client code 🤔 we could perhaps just check periodically, but if there's a better way, that'd be good.