-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netlify Deploy workflow fails #148
Comments
After a bunch of trial and error, I finally figured out how to deploy this repo to Netlify from a fresh clone. git clone https://github.com/styxlab/next-cms-ghost.git
cd next-cms-ghost
yarn
# Development
yarn dev
# Export a static site to /out directory
yarn export
# Rename the output folder, or change the config file at netlify.toml accordingly
mv out out_publish
# Deploy
netlify deploy --prod I'm sure those steps are very basic, but for me having absolutely no experience with yarn/nextjs/netlify it wasn't all that easy to figure out. May I suggest adding the full workflow to the readme? Side note: this is just a solution for deploying from a local install but the Netlify one-click button from the readme is still failing with the same error. |
@Garfounkel Thanks for the heads up because my deploy was failing as well. Did you update the |
I haven't try deploying solely from Netlify's UI, but I think what you suggested should work. I would check if you can't specify somewhere in the Netlify UI that the build command is I also suggest trying to deploy manually if you haven't already:
|
@Garfounkel Thanks for the response. The manual deployment worked fine when I did it previously. In the Netlify UI you certainly can set the build commands but the
When I try to deploy without the plugins I get a different type error:
I'll see if I can solve it. |
Just updating again that I've tried other configurations in the build process for netlify and removing the plugins for next but still always getting a build error. I am about to give up on this. |
Thanks for following up on this issue. I will have a look myself when I return from vacations. Netlify changed and updated a bunch of things for Next.js deploys and this repo must be updated for that. According to the Netlify docs, this repo needs at least 3 changes
To get ISR and next/images working there are more changes needed, but those three might be sufficient to get the Netlify button working again. |
Thanks for following up. Happy new year. I think I scoured the Netlify docs and already attempted these changes you mentioned but it did not build. I believe it has to do with the next/images as you've said but I had a difficult time debugging that in the build log. I'll try your changes and report back my findings with the logs. |
PR #152 should fix the netlify deploy button. Things to note:
Further work is needed on (1) next/images and (2) ISR. Both features are currently switched off on netlify builds. I will open new issues for both topics. @toreylittlefield, @Garfounkel: Can you confirm that the netlify button is working for you as well? |
It fixed in my tests, so closing. |
Trying to deploy through Netflify using the deploy button from the readme (
) fails saying the directory "out_publish" wasn't found.
I also tried deploying this repo myself, from a fresh clone I ran the following commands:
Which resulted in the same error.
The text was updated successfully, but these errors were encountered: