-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open the images in full-screen display on click #162
Comments
I think that was already implemented on PR #158 by @laurentmmeyer. |
Maybe it works for simple images only and not for galleries? |
@styxlab @laurentmmeyer |
true, it only works for the NextImage component at the moment, but could be easily extended. May I ask you why you don't next/images? It usually has a big impact on loading speeds. |
I really like its impact but at the time I cloned your repository I was not a big fan of the structure of the generated URLs at the end, I preferred the one I set up with my custom domain S3 side. |
Serving directly from S3 is not a good idea, you need a CDN to serve images from. |
Yes but I'm using CloudFront with the custom domain that I'm talking about. |
I don't intend to do anything about it in the near future as I think most people will use |
@styxlab, This is more a feature request/suggestion than anything else.
The way the images work at the moment is great, I think it'll be even nicer to have them opened in full-screen (or at least in a wider way) on click on each.
Do let me know what you think about, please.
The text was updated successfully, but these errors were encountered: