Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the images in full-screen display on click #162

Closed
dassiorleando opened this issue Jan 23, 2022 · 8 comments
Closed

Open the images in full-screen display on click #162

dassiorleando opened this issue Jan 23, 2022 · 8 comments

Comments

@dassiorleando
Copy link
Contributor

@styxlab, This is more a feature request/suggestion than anything else.

The way the images work at the moment is great, I think it'll be even nicer to have them opened in full-screen (or at least in a wider way) on click on each.

Do let me know what you think about, please.

@styxlab
Copy link
Owner

styxlab commented Jan 23, 2022

I think that was already implemented on PR #158 by @laurentmmeyer.

@dassiorleando
Copy link
Contributor Author

dassiorleando commented Jan 23, 2022

Maybe it works for simple images only and not for galleries?
I'm going to test it more and revert.
Thanks for the reference.

@dassiorleando
Copy link
Contributor Author

@styxlab @laurentmmeyer
Looks like it works only if we use Next Image Optimisation, or is there anything I missed somewhere?
I'm not using that feature at all.

@styxlab
Copy link
Owner

styxlab commented Jan 23, 2022

true, it only works for the NextImage component at the moment, but could be easily extended. May I ask you why you don't next/images? It usually has a big impact on loading speeds.

@dassiorleando
Copy link
Contributor Author

dassiorleando commented Jan 23, 2022

I really like its impact but at the time I cloned your repository I was not a big fan of the structure of the generated URLs at the end, I preferred the one I set up with my custom domain S3 side.
I may think about it even more today.

@styxlab
Copy link
Owner

styxlab commented Jan 23, 2022

Serving directly from S3 is not a good idea, you need a CDN to serve images from.

@dassiorleando
Copy link
Contributor Author

dassiorleando commented Jan 23, 2022

Yes but I'm using CloudFront with the custom domain that I'm talking about.
S3 + CloudFront as CDN.

@styxlab
Copy link
Owner

styxlab commented Feb 10, 2022

I don't intend to do anything about it in the near future as I think most people will use next/images. However, I am open to any PRs that extend the current solution to custom image optimizers. Please open a new case/PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants