Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wall emissivity array out of bounds #2211

Closed
3 tasks done
maxaehle opened this issue Feb 14, 2024 · 1 comment
Closed
3 tasks done

Wall emissivity array out of bounds #2211

maxaehle opened this issue Feb 14, 2024 · 1 comment
Labels

Comments

@maxaehle
Copy link
Contributor

Describe the bug

The serial regression test p1rad, which runs SU2_CFD on TestCases/radiation/p1model/configp1.cfg, has a heap-buffer-overflow in CConfig::GetWall_Emissivity according to Clang's address sanitizer.

According to my printf debugging, nMarker_Emissivity is 2 and Wall_Emissivity is {"left", "right"} (matching the cfg file), but CRadP1Solver::BC_Marshak calls GetWall_Emissivity with the marker string "upper".

Bug report checklist

Desktop (please complete the following information):
Ubuntu 22.04 with Clang++ 16.0.6, MPI disabled, SU2 at current develop branch, commit f9f7a01.

@pcarruscag
Copy link
Member

Looks like BC_Marshak is used for all boundary types of the radiation solver, maybe we need to return 0 emissivity for markers that are not found in the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants