Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority to presence #48

Closed
sualko opened this issue Jun 18, 2014 · 6 comments
Closed

Add priority to presence #48

sualko opened this issue Jun 18, 2014 · 6 comments
Milestone

Comments

@sualko
Copy link
Member

sualko commented Jun 18, 2014

http://xmpp.org/rfcs/rfc6121.html#presence-syntax-children-priority

@sualko sualko added this to the 1.0 milestone Jun 18, 2014
sualko added a commit that referenced this issue Jun 25, 2014
@sualko
Copy link
Member Author

sualko commented Jun 25, 2014

@davodego maybe you want to test this.

@sualko sualko closed this as completed Jun 25, 2014
@zauberstuhl
Copy link
Contributor

@sualko hi, I just finished implementing offline support for our xmpp server (see diaspora/vines#30)
and I discovered that jsxc sends zero presence-priority's on default. In my opinion you should send at least for the 'Online'-presence a positive priority. Otherwise jsxc will receive no offline messages on default.

(source 8.5.2.1.1 xmpp message rules)

@sualko
Copy link
Member Author

sualko commented Oct 27, 2014

Next time, it would be create if you would open a new issue, because it's easier to organize.

On default jsxc sends no priority, not even a zero and on init you can set some default values. So I see no problem.

@zauberstuhl
Copy link
Contributor

Next time, it would be create if you would open a new issue, because it's easier to organize.

next time :)

On default jsxc sends no priority, not even a zero

if you are not sending something a xmpp server will handle it as zero.

on init you can set some default values. So I see no problem.

perfect! was not aware of that I can change priority, too. Thanks.

@sualko
Copy link
Member Author

sualko commented Oct 28, 2014

if you are not sending something a xmpp server will handle it as zero.

You are right. But I don't get the next point:

Otherwise jsxc will receive no offline messages on default.

In the spec theres nothing about a positive priority for offline messages:

For message stanzas, the server MAY choose to store the stanza on behalf of the user and deliver it when the user next becomes available

@zauberstuhl
Copy link
Contributor

checkout the rule section:

If all of the available resources have a negative presence priority then the server SHOULD either (a) store the message offline for later delivery or (b) return a stanza error to the sender, which SHOULD be <service-unavailable/>.

but you are right I made a mistake. The RFC is talking only about non-negative values. Means I should deliver to zero and positive values. Sorry for the confusion :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants