fix: req end event isn't called because res.end is called before #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing instant-markdown/vim-instant-markdown#171
I think due to change in HTTP low level implementation of Nodejs 10.x or 12.x but the orginal code is wrong because
res.end()
was called before events handling was done. So theend
is never trigger in some nodejs implementation especially nodejs 12.x.This issue in nodejs repo confirm my thoughts.
We should implement the close event too.