Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CountdownController to show readable time #345

Closed
kwhandy opened this issue Apr 4, 2024 · 2 comments · Fixed by #351
Closed

CountdownController to show readable time #345

kwhandy opened this issue Apr 4, 2024 · 2 comments · Fixed by #351

Comments

@kwhandy
Copy link

kwhandy commented Apr 4, 2024

Current view for time display of countdown_controller's time in minute:second format is 2:9 instead showing 02:09, I wonder is this a bug or any reason behind this?

@Sub-Xaero
Copy link
Owner

Hello @kwhandy ,

That's entirely on me, I wrote the Countdown controller according to my own use-case at the time which was to show the countdown in words, like I display in the examples:
Screenshot 2024-04-17 at 16 08 08

But zero-padded is a very valid use-case too, so I've added this functionality behind a config flag in #351. If you set data-countdown-pad-zeros-value="true" on your element, it will now have the desired effect:

Screenshot 2024-04-17 at 16 35 56

I'll cut a new release for this shortly.

Sub-Xaero added a commit that referenced this issue Apr 17, 2024
…rol whether hours, minutes and seconds are output as zero-padded or not. Also fixed `removeUnused` behaviour.

Closes #345
@kwhandy
Copy link
Author

kwhandy commented May 7, 2024

whoa! tysm, appreciate the response:))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants