Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arg labels for send, subscribe #10

Merged
merged 2 commits into from Mar 25, 2022
Merged

Conversation

gordonbrander
Copy link
Collaborator

Fixes #7

Per https://www.swift.org/documentation/api-design-guidelines/#argument-labels,

If the first argument forms part of a grammatical phrase, omit its label.

This is the case for store.send(_), so we remove the label.

When the first argument forms part of a prepositional phrase, give it an argument label.

We subscribe to a publisher, therefore store.subscribe(to:)

@gordonbrander gordonbrander changed the title Remove extraneous arg labels from send, subscribe Update arg labels for send, subscribe Mar 25, 2022
@gordonbrander gordonbrander merged commit 180d455 into main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate send(action:) in favor of send(_)
1 participant