Create binding form that does not set animation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if no animation was passed to binding, we would send `withAnimation(nil)`. However, we don't want to set withAnimation(nil) as this may override withAnimation called elsewhere. Instead, we now introduce two forms of `Store.binding`: Store.binding(get:set:) Store.binding(get:set:animation:) The first form does not call withAnimation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if no animation was passed to binding, we would send
withAnimation(nil). However, we don't want to setwithAnimation(nil)unless explicitly asked, as this may override withAnimation called elsewhere.Instead, we now introduce two forms of
Store.binding:The first form does not call withAnimation, leaving the transaction state alone.