Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Content-Length headers when writing to a sphere. #582

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Aug 8, 2023

First pass on this; we could also add length when linking, either the size of the pointer or 0

@cdata
Copy link
Collaborator

cdata commented Aug 8, 2023

Just as a general comment, I want to call attention to #498 . There isn't a strict path dependency here, but I think the overall priority if #498 is higher, and that a more wholesome solution to computing Content-Length would arise from fixing it.

Copy link
Contributor

github-actions bot commented Jan 16, 2024

Test flake analysis

status platform features toolchain
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers stable
🟢 windows-latest test-kubo,headers stable
🟡 ubuntu-latest test-kubo,headers nightly
🟢 macos-13 test-kubo,headers stable
🟢 macos-13 test-kubo,headers,rocksdb stable

Flake summary for ubuntu-latest, test-kubo,headers, nightly

     Summary [  41.129s] 177 tests run: 177 passed (1 flaky), 1 skipped
   FLAKY 2/5 [   1.806s] noosphere-ns dht::node::test::test_dhtnode_bootstrap

Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdata cdata merged commit 6cedf47 into main Jan 18, 2024
22 checks passed
@cdata cdata deleted the content-length branch January 18, 2024 19:33
@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants