Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add axum tooling to provide w3c tracecontexts in response payloads #780

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

justinabrahms
Copy link
Contributor

I'm not clear on which compiler flags we should expect observability.. but I assume all of them?

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Test flake analysis

status platform features toolchain
🟢 ubuntu-latest test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟡 macos-13 test-kubo,headers stable
🟢 windows-latest test-kubo,headers stable
🟡 ubuntu-latest test-kubo,headers nightly
🟢 macos-13 test-kubo,headers,rocksdb stable

Flake summary for macos-13, test-kubo,headers, stable

     Summary [  53.899s] 176 tests run: 176 passed (1 flaky), 1 skipped
   FLAKY 2/5 [  15.493s] noosphere::distributed_stress multiplayer::orb_can_render_peers_in_the_sphere_address_book

Flake summary for ubuntu-latest, test-kubo,headers, nightly

     Summary [  44.870s] 176 tests run: 176 passed (1 flaky), 1 skipped
   FLAKY 2/5 [  16.781s] noosphere::distributed_stress multiplayer::orb_can_render_peers_in_the_sphere_address_book

@jsantell
Copy link
Contributor

Pushed a change that adds an on-by-default feature flag for enabling this in our two HTTP servers:

  • Adds an observability flag to noosphere-cli (on by default) to toggle noosphere-gateway's otel capabilities.
  • Same with noosphere-ns for orb-ns, enabled by default.

@jsantell jsantell merged commit 4d84bea into main Jan 16, 2024
21 checks passed
@jsantell jsantell deleted the tracecontext-response-headers branch January 16, 2024 18:58
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants