New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari-style tabs #29
Comments
One way to achieve this would be deciding to remove PSMTabBarControl in #14 - which might be preferable as it is very old technology. And while an implementation of #1 might need a tabbing solution again that is more flexible than the cocoa default one, it should not prevent intermediate progress, as it will be a more long term feature. So to be clear: I’m not opposed generally speaking. If so, please do it in a way that has a good design tool to packaged art process (e.g. I just setup an afdesign document for the current style - so go along the lines of this - single export out of the art tool, and then at max a postprocessing script that works), or explore #14 way of removing PSMTabBarControl. |
I would certainly be in favor of the iterative approach of trying to bootstrap on top of AppKit's now native tabs -- is there anywhere in the documentation that outlines the minimum macOS version that you want to support? That would be my only concern for doing that. |
The current release has a deployment target of 10.11 - but I’m not opposed to raise this quite quickly if its needed or has benefits, now that one more recent compatible version for 10.11 and up is out. |
So just turning on automatic tabbing surprisingly "works", except of course you now get both SubEthaEdit's and AppKit's tabs (nested tabs! that's basically project view right there!). However, there seems to be basically zero documentation for NSWindowTab, etc. so its going to be a fair bit of trial and error. |
It's also slightly faulty (probably because we have overlapping implementations and selectors). Had to disable this "yo dawg" moment pretty close to release as I didn't come across it before. See |
Closing for now with the commit done in #73 |
Would you be opposed to me making the tabs in SubEthaEdit match Safari's current style (the ones currently match Safari's old style). Want to make sure that's wanted before spending any time on it.
The text was updated successfully, but these errors were encountered: