Fix the initial hour on iOS #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheGlorySaint can you take a look? |
|
@all-contributors please add @saifb for code |
|
I've put up a pull request to add @saifb! 🎉 |
|
Thank You @saifb for your commit and your fix for that issue. I have added you as a contributor for code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue details here: #54
Replicating the bug
iosStylePickerset totruevalueof TimeOfDay in the P.M. time period (ie: 4 PM)Why does this happen
Notice that when you adjust the hours, the "am" text gets selected. This is because the hour is initialized with respect to the time period (meaning, out of 12 instead of 24). However, the wheel itself has 24 options, not 12.
How to fix this
Simply disregrard the time period when calculating the "initial hour" for the
DisplayWheel