Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a center point mistake #2

Open
renlongyu opened this issue Apr 29, 2015 · 1 comment
Open

a center point mistake #2

renlongyu opened this issue Apr 29, 2015 · 1 comment

Comments

@renlongyu
Copy link

in file "RecordingCircleOverlayView.m", line34 :
CGPoint arcCenter = CGPointMake(CGRectGetMidY(self.bounds), CGRectGetMidX(self.bounds));
I think right way is:
CGPoint arcCenter = CGPointMake(CGRectGetMidX(self.bounds), CGRectGetMidY(self.bounds));
arcCenter x and y is contrary

@unknownv2
Copy link

Agreed!

I also changed line 35 from:
CGFloat radius = CGRectGetMidX(self.bounds) - insets.top - insets.bottom;
to:
CGFloat radius = CGRectGetMidY(self.bounds) - insets.top - insets.bottom;

Together with your fix, that seems to have fixed the display problem I was having since it would only show a section of the full circle in the simulator and on a device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants