Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline support #24

Closed
25 tasks done
sumnerevans opened this issue Sep 11, 2019 · 3 comments
Closed
25 tasks done

Offline support #24

sumnerevans opened this issue Sep 11, 2019 · 3 comments
Assignees

Comments

@sumnerevans
Copy link
Member

One of the primary goals was to make sure that the offline usage was good.

  • Convert the can_* functions to be not dependent on the ping state.

  • Get rid of can_service_requests and instead use ping state and initial_sync.

  • Use the GTA can_* only, because the caching adapter should basically inherit from that.

  • Disable certain features that require being online.

  • Need to be able to detect being offline.

  • Invalidations should not be destructive. That way, we can just use the previous values when we are unable to fetch.

  • The UI should have some indication of being offline. Maybe just something in the header or maybe in the dropdown, not sure.

  • Albums browsing needs to be refactored. In online mode, we can just use the server function, but in offline mode:

    • When random is selected, just grab a random sample of the downloaded albums.
    • When genre is selected, iterate though the local albums for albums of the genre.
    • When year is selected, find all albums in the year range.
    • When alphabetical is selected, sort all of the albums according to the secondary sort param.
  • Search (two ideas here: combine offline and online results always, or use two different searches when in offline/online modes)

@sumnerevans
Copy link
Member Author

marked this issue as related to #133

@sumnerevans
Copy link
Member Author

closed via merge request !40

@sumnerevans
Copy link
Member Author

marked this issue as related to #221

@sumnerevans sumnerevans self-assigned this Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant