Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Syntax highlighting HEREDOC #430

Closed
cyclotron3k opened this issue May 25, 2016 · 3 comments
Closed

[Ruby] Syntax highlighting HEREDOC #430

cyclotron3k opened this issue May 25, 2016 · 3 comments
Labels
T: bug A bug in an existing language feature

Comments

@cyclotron3k
Copy link

cyclotron3k commented May 25, 2016

It's valid Ruby to include more code on the same line as the opening tag of a HEREDOC block:
single_heredoc

Multiple consecutive HEREDOC blocks are also valid:
multi_heredoc

And it can get even more complicated:
complex_heredoc

@wbond
Copy link
Member

wbond commented May 25, 2016

We should be able to handle the situation where additional code is specified on the line where the heredoc starts, however it may not be possible to handle the stacked heredocs.

@wbond wbond added the T: bug A bug in an existing language feature label Jun 1, 2016
@wbond
Copy link
Member

wbond commented Jun 8, 2016

This will be fixed by https://github.com/sublimehq/Packages/tree/ruby-clear_scopes, but that won't be merged until 3115 is released since it uses new functionality in the .sublime-syntax file format.

@wbond
Copy link
Member

wbond commented Jul 22, 2016

The primary issue was resolved with build 3116. There isn't really a way to handle the nested heredocs if they are different embedded syntaxes since they would be added and popped off of the stack in reverse order than the way Ruby would interpret them.

I don't currently foresee us being able to handle the multiple, nested, different syntax heredocs without a significant rewrite of how syntaxes work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug A bug in an existing language feature
Projects
None yet
Development

No branches or pull requests

2 participants