stash pop hits bug in git 2.24.0

[stevenkaras]

Version info

• OS: Ubuntu 16.04
• Build: 1119
• Git: 2.24.0

Description

When editing commit messages, I have a habit of hitting ctrl+s. After upgrading git to the latest version, there is apparently an issue with git stash and the --quiet flag. The gist of the bug is that it clears the index, making it appear that all the files in the repository have been removed. This leads to SublimeMerge listing every single file as removed and for large repositories causes a huge spike in memory usage (for reference, this happened in our monorepo and SM jumped from ~160MB resident to around 2.4GB).

I don't necessarily expect SublimeMerge to do anything with this bug, but hopefully it will be easier to discover than the git bug and show up in search results and save someone else searching for the relevant bug reports for an hour.

Steps to reproduce

Steps to reproduce the behavior:

1. Make some changes in a repository.
2. Stash those changes
3. Pop the stash

[Bjarno]

The same issue is happening on my system. Really confusing behavior of Sublime Merge.

[stdedos]

I don't necessarily expect SublimeMerge to do anything with this bug

I would expect that I could "hack" the command not to be quiet, for the time being :-D

[stevenkaras]

Looks like there is an actual bug here:

it should show that it's running git stash pop -q

[mwean]

This is happening for me also, and it usually crashes the app. I use stashes all the time in Tower, and I've never had this issue, so there must be some way around it.

[themilkman]

I also saw this behavior under linux. I'd hope that the git devs will respolve it soon.

[martijnboers]

Also affected, subscribing

[themilkman]

If I see it correctly (couldn't test it yet) it should be resolved in git 2.25 (see https://github.com/git/git/blob/v2.25.0/Documentation/RelNotes/2.25.0.txt )

[themilkman]

Could just test it, works on my Linux machine as expected again with git 2.25 👍

[stdedos]

It is so lovely that no-one from the team is responding here ❤️

Sublime Text repositories are much more responsive/active, which makes this strange.

[stevenkaras]

Looks like this was resolved in sublime merge build 2020 with the release note:

Closing this as a result.

[themilkman]

Just for the records, respectively fixed on the dev Build 1201 in February :)