Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redhat-developer/yaml-language-server 0.9.0 #9

Closed
jfcherng opened this issue Jul 8, 2020 · 6 comments · Fixed by #10
Closed

Update redhat-developer/yaml-language-server 0.9.0 #9

jfcherng opened this issue Jul 8, 2020 · 6 comments · Fixed by #10

Comments

@jfcherng
Copy link
Collaborator

jfcherng commented Jul 8, 2020

Changelog: https://github.com/redhat-developer/yaml-language-server/blob/0.9.0/CHANGELOG.md#090

@jfcherng jfcherng changed the title Update redhat-developer/yaml-language-server 0.8.0 Update redhat-developer/yaml-language-server 0.9.0 Jul 13, 2020
@jfcherng
Copy link
Collaborator Author

jfcherng commented Jul 21, 2020

🤔 Gonna use my own LSP-yaml.

RandomByte added a commit that referenced this issue Aug 9, 2020
RandomByte added a commit that referenced this issue Aug 9, 2020
https://github.com/redhat-developer/yaml-language-server/blob/0.9.0/CHANGELOG.md

Now consuming the package directly from the npm registry instead of a
custom built tarball.

Resolves #9
RandomByte added a commit that referenced this issue Aug 9, 2020
https://github.com/redhat-developer/yaml-language-server/blob/0.9.0/CHANGELOG.md

Now consuming the package directly from the npm registry instead of a
custom built tarball.

Resolves #9
@RandomByte
Copy link
Collaborator

It took me a while to find time to to update this project and properly test it. Please always feel free to propose a PR or give feedback if you tested any of the existing PRs.

I don't want to claim ownership over this repository (it's open source and part of the "SublimeLSP" org after all), just some responsibility.

May I ask, what's the difference to your LSP-yaml project now? Should we include some of those changes in this project? Do you want to become a contributor here?

@jfcherng
Copy link
Collaborator Author

jfcherng commented Aug 9, 2020

May I ask, what's the difference to your LSP-yaml project now? Should we include some of those changes in this project? Do you want to become a contributor here?

It looks like they are the same now except for folder naming and mine only works on ST 4 (I mean to do that because I love using dotted settings) 👍

I would like to promote using language-server as the server directory name for consistency but, well, not really important.

@jfcherng
Copy link
Collaborator Author

jfcherng commented Aug 9, 2020

You can use the dependabot like https://github.com/jfcherng-sublime/LSP-yaml/blob/master/.dependabot/config.yml to auto create an PR on GitHub if there is a new release for the server on GitHub like https://github.com/jfcherng-sublime/LSP-yaml/pull/1.

.gitattributes is a good thing too so we don't have to deploy non-productional files into the release package, which users will download via Package Control.

@jfcherng
Copy link
Collaborator Author

jfcherng commented Aug 9, 2020

I am going to switch back to sublimelsp/LSP-yaml and delete my repo soon since my repo doesn't provide anything extra.

@RandomByte
Copy link
Collaborator

Awesome, thanks!

Should I just add you as a contributor so you can manage this repository as well? I think that just makes sense, given your experience. If you are happy with a change you can then make the releases yourself. Or request a review if you want any feedback.

I would like to promote using language-server as the server directory name for consistency but, well, not really important.

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants