Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the CoreDNS plugin to client-go 0.26 #1008

Closed
skitt opened this issue Dec 14, 2022 · 0 comments · Fixed by #1066
Closed

Upgrade the CoreDNS plugin to client-go 0.26 #1008

skitt opened this issue Dec 14, 2022 · 0 comments · Fixed by #1066
Assignees
@tpantelis
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request maintenance Small, unplanned tasks related to ongoing maintenance
Projects
Submariner Project 0.15

Comments

@skitt
Copy link
Member

skitt commented Dec 14, 2022

CoreDNS has now been updated upstream so that client-go can be updated to 0.26 (coredns/coredns#5806), with

go get github.com/coredns/coredns@master

However this brings in kubernetes/kubernetes#112774, for which coredns/gateway/controller.go and the associated unit tests need to be updated (dynamic.NewForConfig now returns a pointer to a concrete type, not an interface; see also https://github.com/golang/go/wiki/CodeReviewComments#interfaces).
@skitt skitt added enhancement New feature or request dependencies Pull requests that update a dependency file maintenance Small, unplanned tasks related to ongoing maintenance labels Dec 14, 2022
@skitt skitt added this to To do in Submariner Project 0.15 via automation Dec 14, 2022
This was referenced Jan 23, 2023
Merged
Merged
@tpantelis tpantelis moved this from To do to In Review in Submariner Project 0.15 Jan 23, 2023
Submariner Project 0.15 automation moved this from In Review to Done Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpantelis tpantelis

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request maintenance Small, unplanned tasks related to ongoing maintenance
Projects
No open projects
Submariner Project 0.15
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump coredns/coredns to the latest master tpantelis/lighthouse
2 participants
@skitt @tpantelis