Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images should be rebuilt with the release tag #941

Open
skitt opened this issue Mar 7, 2024 · 0 comments
Open

Images should be rebuilt with the release tag #941

skitt opened this issue Mar 7, 2024 · 0 comments
Assignees

Comments

@skitt
Copy link
Member

skitt commented Mar 7, 2024

The release process currently retags images:

  • for the first GA, the last RC images are retagged (to avoid unintended changes being released)
  • for any other release, the last images built on the appropriate release branch are retagged

Now that binaries embed version information, this results in misleading information being shown to users, e.g. using subctl show versions. For example in submariner-io/subctl#971, the RC1 images were tagged using the last built image on the 0.16 branch, embedding the commit information from those images instead of 0.16.0-rc1 (e.g. release-0.16-d1b6c9e194f8 for the gateway and route-agent images), and reproducing that for the GA images instead of 0.16.0. As a result, even though the setup is correctly running 0.16.0 images, that is not apparent.

Limiting the risk of releasing images with unintended changes is still desirable, so fixing this isn’t as simple as building the relevant branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants