Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonBridgeOptions not compatible with Node.js #17

Closed
huan opened this issue Aug 1, 2017 · 6 comments
Closed

PythonBridgeOptions not compatible with Node.js #17

huan opened this issue Aug 1, 2017 · 6 comments

Comments

@huan
Copy link
Collaborator

huan commented Aug 1, 2017

According to the Node.js types:

    export interface ProcessEnv {
      [key: string]: string | undefined
    }

We need to compatible with it by:

-  env?: { [key:string]: string; };
+  env?: { [key: string]: string | undefined; };
huan added a commit to huan/node-python-bridge that referenced this issue Aug 1, 2017
@munro munro closed this as completed in 133bb13 Aug 1, 2017
munro pushed a commit that referenced this issue Aug 1, 2017
@huan
Copy link
Collaborator Author

huan commented Aug 1, 2017

Ah, you are so fast!

Please update npm. 👍

@munro
Copy link
Member

munro commented Aug 1, 2017

heh I'm at the computer, also nobody got time for test build

@huan
Copy link
Collaborator Author

huan commented Aug 1, 2017

Bravo! I'm using the new npm now.

@huan
Copy link
Collaborator Author

huan commented Aug 1, 2017

Thanks for inviting me for collaborating in this project.

What I'm doing now is to use python-bridge to integrate Node.js with Tensorflow in Python, the project name is FaceNet, it's a FaceNet Node.js Module for easy face recognition, verification, and clustering. See more at https://github.com/zixia/facenet .

It seems work like a charm, so I will use it and try to contribute more in the future.

Thank you for the awesome project again!

@munro
Copy link
Member

munro commented Aug 1, 2017

Awesome 😱 I've been wanting to play with tensorflow, I've been building some models with with sklearn. I've also distributing computation computation with PySpark, which is a ton of fun when you have 12 nodes crushing 100s of GiBs of data in seconds!

IntelliJ has a feature that let's you inject syntax highlighting for embedded languages—you may be able to pull it off with your IDE as well! It's not perfect though.. also sorry, I had to add ; because it was visually yelling at me lol

image

@huan
Copy link
Collaborator Author

huan commented Aug 2, 2017

Great to hear that you are also interested in Tensorflow!

I'm using vscode because it has the best support for TypeScript, so I also use vscode as my Python IDE, it seems good enough for me now.

It seems you are already playing with facenet now, how do you think my project, do you think this kind of encapsulates will be useful?

I once have an idea that builds a tensorflow-bridge, that just bridge all the Python Tensorflow APIs to Node.js, use python bridge.

P.S. there's two tensorflow binding for Node.js(as far as I know now):

  1. https://github.com/nodejs-tensorflow/nodejs-tensorflow, @JIoJIaJIu start to support TypeScript after my suggestion.
  2. https://github.com/yorkie/tensorflow-nodejs @yorkie seems not like the idea of TypeScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants