Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when streaming video on ubuntu/linux #15

Closed
subnub opened this issue May 26, 2020 · 2 comments
Closed

Memory leak when streaming video on ubuntu/linux #15

subnub opened this issue May 26, 2020 · 2 comments

Comments

@subnub
Copy link
Owner

subnub commented May 26, 2020

I am going to open this issue myself to let users know I am aware of it, and am currently looking for a fix. Any advice would be appreciated for this, because I am having lots of trouble finding the cause of it.

There appears to be a memory leak when streaming video, this is most noticeable on Ubuntu when playing large videos (200mb+), where even after the user stops streaming the video, none of the memory gets released. It's odd because this does not seem to be an issue on macOS as far as I can tell.

I also made a demo for this where I stripped out all the encryption and complicated parts, the only thing that is somewhat complicated is it attempts to destroy a stream if another one is issued by the same client, which seems to help a little bit with the memory issue (and fixes and I/O issue), but it still will not release the memory, and will sometimes even crash because the server ran out of it.

Demo: https://github.com/subnub/video-streaming-test-no-encryption
Note: You should probably replace the default video 'bunny.mp4' with something larger, so you can see the memory leak easier.

@nikita-fuchs
Copy link

nikita-fuchs commented Sep 15, 2020

Hey, can you point out the code responsible for the streaming more precisely ?

EDIT: Found it

@subnub
Copy link
Owner Author

subnub commented Jan 2, 2021

This has been fixed in the newest version of myDrive.

@subnub subnub closed this as completed Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants