Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Runnables and Bundle from Coordinator #41

Closed
cohix opened this issue May 16, 2021 · 1 comment · Fixed by #42
Closed

Decouple Runnables and Bundle from Coordinator #41

cohix opened this issue May 16, 2021 · 1 comment · Fixed by #42
Labels
refactor Something that needs to be re-designed to further code health, modularity, etc

Comments

@cohix
Copy link
Contributor

cohix commented May 16, 2021 •
edited

In order to facilitate #40 , access to the bundle, Directive, and Runnables will need to be decoupled from the Coordinator. The coordinator cannot be the owner of those things, as it will make things like dynamic loading and unloading difficult.

I propose an AppSource interface that dynamically returns the Directive and Runnables to the Coordinator rather than the current setup of the Coordinator loading and holding everything.
@cohix cohix added the refactor Something that needs to be re-designed to further code health, modularity, etc label May 16, 2021
This was referenced May 16, 2021
Closed
Closed
@cohix
Copy link
Contributor Author

cohix commented May 20, 2021

Depends on suborbital/reactr#100

@cohix cohix mentioned this issue May 21, 2021
Merged
@cohix cohix closed this as completed in #42 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Something that needs to be re-designed to further code health, modularity, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to use AppSource suborbital/e2core
1 participant
@cohix