Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handler: Log already committed responses #22

Closed
javorszky opened this issue Feb 15, 2023 · 0 comments · Fixed by #23
Closed

Error Handler: Log already committed responses #22

javorszky opened this issue Feb 15, 2023 · 0 comments · Fixed by #23
Assignees

Comments

@javorszky
Copy link
Contributor

There was an issue not too long ago where the websocket library could not upgrade the connection, wrote to the http.ResponseWriter, and then returned an error.

There were no logs about it. I think it was because the response has been committed already, at which point the error handler silently returns.

Let's log a committed response anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant