Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental decorators: don't use them? #251

Open
mlenser opened this issue Mar 1, 2024 · 1 comment
Open

Experimental decorators: don't use them? #251

mlenser opened this issue Mar 1, 2024 · 1 comment

Comments

@mlenser
Copy link

mlenser commented Mar 1, 2024

Experimental decorators have presented problems throughout our usage of subsquid. I can't remember all of the instances, but many common solutions don't work with them and making decorators work has been a huge pain for our team.
One example: today we were considering building our indexer with esbuild to avoid cjs/esm issues, but esbuild doesn't work well with decorators. It may be possible to make them work like we've done in a handful of other cases, but it's a huge drag.

Has there been any discussion about not using experimental decorators?

@belopash belopash transferred this issue from subsquid/squid-cli Mar 5, 2024
@eldargab
Copy link
Collaborator

eldargab commented Mar 5, 2024

SDK itself doesn't provide any decorator in its public API.

All decorators present in mapping projects come from peer dependencies - typeorm and type-graphql.

We can do nothing until those projects migrate or we'll provide viable alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@mlenser @eldargab and others