--insert-globals option doesn't work

[shuhei]

This issue doesn't break anything because globals are inserted anyway if they are found in source code. Also, detecting globals are now very fast thanks to mine.

However, cli's --insert-globals option doesn't seem to be working. It fails as follows:

1. browserify --insert-globals=true foo.js
2. bundle()'s insertGlobals option becomes a string "true".
3. insert-module-globals module gets the string "true" as always option.
4. It strictly compares the string "true" against the boolean true and doesn't insert globals.

https://github.com/substack/insert-module-globals/blob/34e5fb7167b858b13ffcc2c73a7827045f2e478e/index.js#L57

This kind of issues can happen to other options too. I couldn't figure out where the right place to fix is, so just opening this issue.

[shuhei]

Also, this issue is obscuring issues related to insertGlobals. Some issues happen on API, but don't on CLI.

[andreypopp]

What if you run browserify --insert-globals foo.js? I think it should be a boolean option.

It strictly compares the string "true" against the boolean true and doesn't insert globals.

That probably should be fixed though.

[shuhei]

What if you run browserify --insert-globals foo.js?

Then it becomes { insertGlobals: "foo.js" } and no entry.

I agree that it should be { insertGlobals: true } though.

[ghost]

In v5 --insert-globals is a boolean option so this issue should be fixed.