Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b.external() fails when passed an array. #930

Closed
philipwalton opened this issue Oct 2, 2014 · 1 comment
Closed

b.external() fails when passed an array. #930

philipwalton opened this issue Oct 2, 2014 · 1 comment

Comments

@philipwalton
Copy link

This works:

require('browserify')('./core').external('./mod');

But this throws:

require('browserify')('./core').external(['./mod']);

Here's the trace:

TypeError: Arguments to path.resolve must be strings
    at Object.exports.resolve (path.js:313:15)
    at Object.exports.relative (path.js:371:18)
    at Browserify.external (/Users/philipwalton/Projects/bundle/node_modules/browserify/index.js:180:36)
    at repl:1:14
    at REPLServer.self.eval (repl.js:110:21)
    at Interface.<anonymous> (repl.js:239:12)
    at Interface.emit (events.js:95:17)
    at Interface._onLine (readline.js:202:10)
    at Interface._line (readline.js:531:8)
    at Interface._ttyWrite (readline.js:760:14)

It seems like only the string case is tested.

@ghost
Copy link

ghost commented Oct 3, 2014

fixed in 5.12.2

@ghost ghost closed this as completed Oct 3, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant