use buffer 3.0.0 #1040
Closed
use buffer 3.0.0 #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Buffer major version: 3.0.0 It has some breaking changes, but they improve compatibility with node! The whole node buffer test suite passes now, thanks to @jessetane! - toString('ascii') and slice('ascii') work correctly (strip off high order bits) - correct exception types thrown (RangeError instead of TypeError in many places) - do not encode partial code units to utf16 - do not encode partial or invalid code points to utf8 - copy() correctly returns length
|
Thanks for the patch! All upgraded in 7.1.0. |
ghost
closed this
|
Relevant PR here, for those interested: feross/buffer#51 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Buffer major version: 3.0.0
It has some breaking changes, but they improve compatibility with node!
The whole node buffer test suite passes now, thanks to @jessetane!