Add pendReady() to factor out repetitive code and facilitate use of the mechanism in plugins #1079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to factor out this pattern that's used in several places into a method:
So this instead:
The reason I didn't name the method
_pendReady
is because I want to suggest exposing / advertising it to facilitate creating plugins that need to do some kind of async setup. For example, create a plugin that needs to register a transform in a specific position, but needs to do some async setup before the transform can be invoked, e.g.:If you approve I can write some documentation.