Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] bring package in line with node's assert.deepEqual #65

Merged
merged 6 commits into from Aug 10, 2019
Merged

[Breaking] bring package in line with node's assert.deepEqual #65

merged 6 commits into from Aug 10, 2019

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 31, 2019 •
edited

@ljharb ljharb mentioned this pull request Jul 31, 2019
Closed
@ljharb
[Breaking] non-Date objects with different [[Prototypes]] are not equal
5f2f2e5 
Date objects are equal when:
 - the timestamp is the same
 - if strict, the [[Prototype]] is the same
 - own properties match, same as normal objects
@ljharb ljharb force-pushed the array_object branch 3 times, most recently from ec1cf9c to 6f4d6d5 Compare August 3, 2019 22:27
@ljharb ljharb changed the title [Breaking] comparing arrays and objects should always fail, per node‘s assert.deepEqual [Breaking] bring package in line with node's assert.deepEqual Aug 7, 2019
@ljharb ljharb force-pushed the array_object branch 2 times, most recently from 05659ac to a159a3a Compare August 9, 2019 20:54
@ljharb ljharb merged commit a159a3a into master Aug 10, 2019
@ljharb ljharb deleted the array_object branch August 10, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ljharb @khirayama @agirorn