Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drive letter casing is inconsistent with node 0.11x #61

Closed
tkellen opened this issue Dec 22, 2014 · 3 comments
Closed

drive letter casing is inconsistent with node 0.11x #61

tkellen opened this issue Dec 22, 2014 · 3 comments

Comments

@tkellen
Copy link

tkellen commented Dec 22, 2014

in node 0.11.14, executing

var resolve = require('resolve');
console.log(require.resolve('resolve'));
console.log(resolve.sync('resolve'));

outputs:

E:\test\node_modules\resolve\index.js
e:\test\node_modules\resolve\index.js

ref gulpjs/gulp#664

@yocontra
Copy link

@substack Any implementation tips? I'm sure somebody in the community could handle this if you pointed them in the right direction

@ljharb
Copy link
Member

ljharb commented Dec 17, 2016

gulpjs/gulp#664 (comment) implies that this behavior would require resolve to unnormalize things, since calling into path.join is necessary for windows compatibility. Is this just about drive letters (which would be relatively trivial to capitalize), or are there other differences we'd run into trying to fix it piecemeal?

@ljharb
Copy link
Member

ljharb commented Jun 17, 2018

Per nodejs/node-v0.x-archive#7799 (comment), this was fixed in nodejs/node-v0.x-archive@016e084, which means it's fixed in v0.11.15.

Given that v0.11.14 is the sole version this is broken in, and 0.11 is both long since EOL and was unstable in its entire line, I'm going to close this as a wontfix.

@ljharb ljharb closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants