Match Windows directories with forward slashes #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an edge case with absolute paths on Windows. After several Browserify transforms, I was ultimately requiring a filepath like,
Admittedly that is a strange looking path, because it's using forward slashes with a Windows drive letter. However, I cross-referenced
require.resolve
and it handled it correctly, so I thought I would track down the discrepancy innode-resolve
. The path was not matching the regex used to differentiate files from modules. Adding a small or to the regex seems to solve this for me.