Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Windows directories with forward slashes #50

Closed
wants to merge 1 commit into from
Closed

Match Windows directories with forward slashes #50

wants to merge 1 commit into from

Conversation

seep
Copy link

@seep seep commented Jul 24, 2014

I had an edge case with absolute paths on Windows. After several Browserify transforms, I was ultimately requiring a filepath like,

D:/some/project/directory/file.js

Admittedly that is a strange looking path, because it's using forward slashes with a Windows drive letter. However, I cross-referenced require.resolve and it handled it correctly, so I thought I would track down the discrepancy in node-resolve. The path was not matching the regex used to differentiate files from modules. Adding a small or to the regex seems to solve this for me.

@ghost
Copy link

ghost commented Jul 25, 2014

Merged into 0.7.4. Thanks for the patch!

@ghost ghost closed this Jul 25, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant