Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfilled set objects fails when using inspect #9

Closed
roy-codefresh opened this issue Jan 15, 2017 · 5 comments
Closed

Polyfilled set objects fails when using inspect #9

roy-codefresh opened this issue Jan 15, 2017 · 5 comments
Assignees
Labels

Comments

@roy-codefresh
Copy link

While using babel-polyfill on IE10 and IE11. The use inspect on a Set object create a fail.

As far is looked, it's seems that isMap function does not distinguish between Set object and Map object.

I was also able to recreate it on node 0.10:

require('babel-polyfill');
var inspect = require('object-inspect');
inspect(new Set([1, 2, 3]));
@ljharb
Copy link
Member

ljharb commented Jan 16, 2017

Does the same thing happen with https://npmjs.com/es6-shim ?

@ljharb
Copy link
Member

ljharb commented Jan 16, 2017

Also, what version of babel-polyfill? core-js fixed a possibly related issue in v2.0

@roy-codefresh
Copy link
Author

Answer to your questions:

  1. This does not happens on es6-shim.
  2. babel-polyfill version is 6.20.0 with core-js@2.4.1

@ljharb ljharb self-assigned this Jan 16, 2017
@ljharb
Copy link
Member

ljharb commented Jan 16, 2017

This is a core-js issue - filed as zloirock/core-js#272.

@ljharb
Copy link
Member

ljharb commented Jul 31, 2017

I've added a workaround. v2.5.0+ of core-js won't have this problem, so the workaround won't be needed.

@ljharb ljharb added the bug label Jul 31, 2017
ljharb added a commit that referenced this issue Jul 31, 2017
 - [New] add support for arrays with additional object keys
 - [Fix] Map/Set: work around core-js bug < v2.5.0 (#9)
 - [Tests] up to `node` `v8.2`, `v7.10`, `v6.11`; fix new npm breaking on older nodes
 - [Dev Deps] update `tape`
 - Only apps should have lockfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants