Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an aggregatetuple without in model key #187

Closed
maeldebon opened this issue Feb 6, 2020 · 2 comments
Closed

Create an aggregatetuple without in model key #187

maeldebon opened this issue Feb 6, 2020 · 2 comments
Assignees

Comments

@maeldebon
Copy link
Contributor

maeldebon commented Feb 6, 2020

Original issue from the substra repository

It is possible to create an aggregatetuple without passing any --in-model-key in the command.

Issue in the backend

The in_models_keys field of an aggregatetuple isn't required and has a minimum length of 0.

As the sole purpose of the aggregatetuple is to aggregate at least 2 models together, the in_models_keys should be required and should have a minimum length of 2.

@jmorel
Copy link
Contributor

jmorel commented Mar 23, 2020

@maeldebon following the short discussion we've had in the PR, I'm moving this issue to the backend repository.

@jmorel jmorel transferred this issue from Substra/substra Mar 23, 2020
@jmorel jmorel self-assigned this Mar 24, 2020
@samlesu
Copy link
Contributor

samlesu commented Mar 30, 2020

As said in the backend PR, there is no reason for adding this restriction. Aggregating nothing or aggregating a single model should be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants