Main Menu: Move Share on

[seanwhe]

Describe the issue:

• Bug
• Change request
• New feature request
• Discussion request

Issue long description:

The Share on item in the Main Menu is a feature not a generic menu. Suggest relocation to the Log menu and/or inclusion in context menus within the Dive List or Dive Profile panels.

Move the setup of the Share on into the File>Preferences dialog under Social.

Operating system:

Subsurface version:

v4.8.4

Steps to reproduce:

Not Applicable

Current behavior:

Share on is a main menu

Expected behavior:

• Move Share on to sub menu Log > Share
• Move Share on config/setup to File > Preferences dialog

Additional information:

Mentions:

[dirkhh]

I think that's mostly a matter of taste.
To the best of my knowledge sharing to Facebook is currently broken and no one cares enough to fix it...

[seanwhe]

Yes it is broken. Yes it could be a matter of taste.
Then again, is social sharing a core intent behind the software?

If the answer to this is no then this feature should not be as prominent as it currently is.

Fact that nobody has an itch to fix it may also be indicating that it is not a prominent or highly desired feature.

[neolit123]

my vote goes to removing the "share on facebook" functionality from the code base along with the "share on" menu.

Then again, is social sharing a core intent behind the software?

i don't think that social sharing has seen much demand or use, so i would say no.

[neolit123]

we are removing the FB feature:
#1958