-
Notifications
You must be signed in to change notification settings - Fork 6
Locks up atom when attempting to type closing </p> #4
Comments
Thanks for the bug report! |
Confirmed. This happens for me too |
Oh crap! This may be my fault in a MUCH deeper way than I could have guessed! Looks like this may be a problem in atom/slick, which is a fork of kamicane/slick, which is a project created by @kamicane, @subtleGradient (that's me), and @fabiomcosta! Awesome! |
Wait, Atom uses Slick? That's new to me, cool! |
@kevinsawicki, do you think this could be a Slick issue? One thing I know is that the Slick parser was never built to handle TextMate 2 selectors. In this language grammar, I'm using a bunch of replacement strings. e.g. |
Actually, it looks like Slick is properly parsing |
@Inviz, do you have an improved version of the Slick parser hanging out anywhere? |
Yeah, I've seen slick lock up in the past which is why Atom ships with fork of it, may need some tweaking to prevent other lockup scenarios |
Yeap, this happens to me too. I'm writing the closing tag element first, and then I add the |
Just published v0.3.3 with a fix for this. Pro Tip™ TextMate handles way more edge cases than Atom. Scopes that select zero characters seem to be a problem. |
Just tested it, works fine. thanks :) |
My fix in v0.3.3 broke JSX close tags without newlines before them. I just released v0.3.4 that fixes that new bug without unfixing this issue also. But I also added some extra scope to hi light improper close tags as invalid. Everything should be working great, but if not, as always, please do let me know. Thanks much! |
To reproduce:
<p>
<
Atom locks up.
The text was updated successfully, but these errors were encountered: